Switch to faster nanors Reed-Solomon implementation #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also create a PR against the upstream Also, since this is such a minor change... what do you think of still using the upstream git apply -v --ignore-whitespace ./third-party/patches/*.patchOr better yet, that could occur in CMakeLists.txt. https://github.com/LizardByte/build-deps/blob/master/cmake/apply_git_patch.cmake |
|
I've submitted the change (with tests) upstream as sleepybishop/nanors#4. |
|
The PR was accepted, so I've changed to point back to the upstream repo. This should be ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches from the Reed-Solomon implementation in moonlight-common-c to a faster one in https://github.com/sleepybishop/nanors
Right now I'm just building with the default
autoshim.hflags which means SSSE3 for x86_64 and NEON for aarch64 (since nanors doesn't support runtime CPU feature detection), but that's still good enough for huge performance improvement over the old code.Screenshot
Profile with old RS implementation:
Profile with new RS implementation (sample counts will vary, so just look at the relative values vs WSASendTo):
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.