Skip to content

Conversation

psyke83
Copy link
Contributor

@psyke83 psyke83 commented Jan 10, 2023

Description

mingw's openssl library is built using the "zlib-dynamic" flag, which invokes LoadLibrary() of zlib1.dll during runtime to allow openssl to function if no zlib.dll is installed.

This is a problem because it prevents static linkage of zlib, thus opening a security vulnerability by which a malicious zlib1.dll can be loaded from any valid system dll search path.

Increase security by including the mingw version of zlib1.dll in the application path, which will override any other versions.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@psyke83 psyke83 marked this pull request as ready for review January 10, 2023 03:16
mingw's openssl library is built using the "zlib-dynamic" flag, which
invokes LoadLibrary() of zlib1.dll during runtime to allow openssl to
function if no zlib.dll is installed.

This is a problem because it prevents static linkage of zlib, thus
opening a security vulnerability by which a malicious zlib1.dll can
be loaded from any valid system dll search path.

Increase security by including the mingw version of zlib1.dll in the
application path, which will override any other versions.
@ReenigneArcher ReenigneArcher merged commit b405888 into LizardByte:nightly Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants