fix submodule names #725
Merged
fix submodule names #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested a manual addition: Your change looks like it replicates how git would natively format any new addition to |
20566ae to
a3bb142
Compare
a3bb142 to
37d9075
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fix issues with initializing submodules. I have been unable to initialize submodules at all until I made this change.
Todo:
build-depsworkflow step that creates the PR against SunshineScreenshot
Issues Fixed or Closed
Resolves this error
$ git submodule sync; git submodule update --recursive Synchronizing submodule url for 'third-party/Simple-Web-Server' Synchronizing submodule url for 'third-party/TPCircularBuffer' Synchronizing submodule url for 'third-party/ViGEmClient' Synchronizing submodule url for 'third-party/ffmpeg-linux-aarch64' Synchronizing submodule url for 'third-party/ffmpeg-linux-x86_64' Synchronizing submodule url for 'third-party/ffmpeg-macos-aarch64' Synchronizing submodule url for 'third-party/ffmpeg-macos-x86_64' Synchronizing submodule url for 'third-party/ffmpeg-windows-x86_64' Synchronizing submodule url for 'third-party/miniupnp' Synchronizing submodule url for 'third-party/moonlight-common-c' Synchronizing submodule url for 'third-party/nv-codec-headers' fatal: not a git repository: C:/Users/ReenigneArcher/Documents/GitHub/LizardByte/Sunshine/third-party/TPCircularBuffer/../../.git/modules/TPCircularBuffer Failed to clone 'third-party/TPCircularBuffer'. Retry scheduled fatal: not a git repository: C:/Users/ReenigneArcher/Documents/GitHub/LizardByte/Sunshine/third-party/miniupnp/../../.git/modules/miniupnp Failed to clone 'third-party/miniupnp'. Retry scheduled fatal: not a git repository: C:/Users/ReenigneArcher/Documents/GitHub/LizardByte/Sunshine/third-party/nv-codec-headers/../../.git/modules/nv-codec-headers Failed to clone 'third-party/nv-codec-headers'. Retry scheduled BUG: submodule considered for cloning, doesn't need cloning any more? Submodule path 'third-party/Simple-Web-Server': checked out '2f29926dbbcd8a0425064d98c24f37ac50bd0b5b' fatal: could not get a repository handle for submodule 'third-party/TPCircularBuffer'Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.