Skip to content

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Jan 7, 2023

Description

This PR introduces a workaround for the issue where Windows systems with no physical mouse connected would not display the mouse cursor (OS behavior since Windows 8). As a workaround, we can enable Mouse Keys for the duration of the streaming session which will force the mouse cursor to be displayed. Fortunately for us, Mouse Keys doesn't see input from SendInput() so we don't have to do anything special to make the number pad work either.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@psyke83
Copy link
Contributor

psyke83 commented Jan 7, 2023

Tested with mouse driver disabled on Windows 10 - seems to be working perfectly.

Mouse Keys is enabled (if not already so) on stream start, making the cursor visible in this situation. Mouse Keys setting is also restored to the original setting before stream began.

@ReenigneArcher ReenigneArcher merged commit 7770b5f into LizardByte:nightly Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants