Skip to content

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Jan 6, 2023

Description

This moves config and other data files out of the root of our Program Files directory into a specific config directory. Only that new config directory has RW access for the Users group now.

I've tested this locally, but it would be nice for someone else to grab the installer from the CI job to make sure it all works seamlessly for them too.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link
Contributor

@brad-richardson brad-richardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me upgrading from v0.16, just one question

@ReenigneArcher ReenigneArcher merged commit c95f54f into LizardByte:nightly Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants