Skip to content

Conversation

brad-richardson
Copy link
Contributor

@brad-richardson brad-richardson commented Jan 6, 2023

Description

Generate stable app id based on name and image data hash. This allows us to stop persisting ids altogether and prevents us filling up moonlight's cache if ids are changing often.

To test:

  • Changing image data without changing path
  • Removing image path
  • Duplicate apps with same name + image path
  • No apps

Issues Fixed or Closed

  • Should fix bug reported on Moonlight discord

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link
Collaborator

@cgutman cgutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the leak, LGTM

@brad-richardson brad-richardson marked this pull request as ready for review January 7, 2023 02:26
@ReenigneArcher ReenigneArcher merged commit 9b6d0b7 into LizardByte:nightly Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants