Skip to content

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 6, 2023

Description

  • Move several Linux builds back to docker. This will resolve dependency issues where the user's environment didn't match our build environment.
  • Adds aarch64 packages for deb and rpm packages.
  • CUDA compute capability is now determined with logical tests in CMakeLists.txt
    • Fedora 36+ only provides GCC-12, and therefore CUDA 12.x is required. It was found that CUDA Compute Capability 35 is not supported in GCC-12, and further discovered that only CUDA Compute Capability 35 was selected in the previous builds. Now, all supported CUDA Compute Capabilities are selected at build time, based on the installed version of CUDA. I could not find an easy way to install GCC < 12 on Fedora.
  • Linux build instructions have been updated to reflect discoveries found during the process of moving back to the Docker images.
  • Adds libmfx as required for Bump ffmpeg #769.
  • Adds Ubuntu patches to Flatpak build dependencies, replacing Add Ubuntu patches #774.

⚠️ aarch64 builds in the Fedora images are painfully slow. I'm not yet sure why this is so much slower than the Ubuntu images.

Todo:

  • get it working
  • extract package from docker buildx
  • create docker images for various distros and versions
    • Debian Bullseye
    • Fedora 36
    • Fedora 37
    • Ubuntu 20.04
    • Ubuntu 22.04
  • update CI
    • remove RPM build from CI
  • publish to docker, tag based on image name
  • double check workflow
  • triple check workflow
  • workflow files to .github repo
    • make sure it works for other LizardByte Docker projects and update them if required (Testing in update docker workflow RetroArcher#190 ... small change required when artifacts are not built in Docker image)
  • add release step to upload release assets

For Another PR:

  • add Arch image (probably a separate PR)
  • remove AUR job from CI (probably a separate PR)
  • remove arch linux package action repo from LizardByte (less to maintain)

Update: Will not build AppImage with Docker. More context:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci/build-with-docker branch 30 times, most recently from f947190 to b3b050e Compare January 7, 2023 00:14
@ReenigneArcher ReenigneArcher force-pushed the ci/build-with-docker branch 8 times, most recently from 0e26267 to b5405d2 Compare January 12, 2023 20:05
@ReenigneArcher ReenigneArcher changed the title build with docker build with docker and improve CUDA compute capability support Jan 12, 2023
@ReenigneArcher ReenigneArcher force-pushed the ci/build-with-docker branch 4 times, most recently from 4477a64 to 73b3dca Compare January 13, 2023 03:42
@ReenigneArcher ReenigneArcher force-pushed the ci/build-with-docker branch 4 times, most recently from 84f64ef to f344668 Compare January 15, 2023 02:00
@ReenigneArcher ReenigneArcher force-pushed the ci/build-with-docker branch 3 times, most recently from a4b8bb4 to d166c1e Compare January 15, 2023 03:34
@ReenigneArcher ReenigneArcher merged commit 3510b86 into nightly Jan 15, 2023
@ReenigneArcher ReenigneArcher deleted the ci/build-with-docker branch January 15, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant