Add an Apply button to the Web UI when running as a Win32 Service #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e156dc6 to
a768b74
Compare
5c8c08a to
3b911a5
Compare
| @@ -765,11 +765,18 @@ <h1 class="my-4">Configuration</h1> | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <div class="alert alert-success my-4" v-if="success"> | |||
| <b>Success!</b> Restart Sunshine to apply changes | |||
| <div class="alert alert-success my-4" v-if="saved && restart_supported"> | |||
There was a problem hiding this comment.
nitpick: Probably a bit reduntant to make 3 duplicated divs for the alert. You can use the tag to wrap the text and then use v-if on the span themselves.
TheElixZammuto
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an "Apply" button to the web UI on systems where Sunshine is running as a service. When clicked, it saves the settings and sends a SIGINT to itself to gracefully terminate. SunshineSvc will then restart it, which will load the new settings.
The "Apply" button only appears on Windows systems where Sunshine is running as a service, but the scaffolding is there to support this on Linux and Mac too (probably by just execing ourselves again).
@TheElixZammuto should probably review the config.html changes for correctness. I'm definitely no web development expert.
Screenshot
Save button success text (when Apply button is available):
Apply button success text:
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.