Skip to content

Conversation

d-s-x
Copy link
Contributor

@d-s-x d-s-x commented Jan 4, 2023

Description

This change fixes Vue binding for config.origin_web_ui_allowed (introduced in beb6bdf). Without the change config value is always ignored and "Only LAN devices may access the web ui" is displayed instead.

Screenshot

n/a

Issues Fixed or Closed

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2023

CLA assistant check
All committers have signed the CLA.

@ReenigneArcher ReenigneArcher force-pushed the fix-web-ui-origin-binding branch from c782149 to 3aa92b2 Compare January 4, 2023 16:51
@ReenigneArcher ReenigneArcher merged commit 1a929cc into LizardByte:nightly Jan 4, 2023
@d-s-x d-s-x deleted the fix-web-ui-origin-binding branch January 4, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants