Skip to content

Fix wayland capture on nvidia #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix wayland capture on nvidia #649

merged 1 commit into from
Jan 4, 2023

Conversation

jhgarner
Copy link
Contributor

@jhgarner jhgarner commented Dec 29, 2022 •
edited by ReenigneArcher
Loading

Description

When using Sway on a Nvidia device, the following error occurs: https://discord.com/channels/804382334370578482/1053022079039058001

To summarize, moonlight displays a black screen after connecting and an opengl error is printed to the sunshine logs. The logs are here: https://gist.github.com/jhgarner/5627b7e48aae7f8b1d9744e3f9011f11

I can consistently reproduce and fix the issue by compiling with and without the code in this branch, but I can't explain why this code fixes it. As far as I can tell, this is just debug logging. My guess is that it's forcing the driver to actually flush parts of the command buffer? Swapping the code out with a glFinish call doesn't fix it though. Maybe Nvidia is just broken?

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the base branch from master to nightly December 29, 2022 17:33
@github-actions
Copy link

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

@ReenigneArcher
Copy link
Member

Thanks for the PR!

There seems to be an issue with your commits. It looks like they were not made by an actual github user. You might have a problem with your git configuration?

Also, you probably want to cleanup the git history if you know how. Otherwise, it's best to start with a clean copy of our nightly branch.

@jhgarner jhgarner force-pushed the wayland-nvidia-fix branch from 5dcf17f to 9e4f288 Compare January 1, 2023 22:27
@jhgarner
Copy link
Contributor Author

jhgarner commented Jan 1, 2023

Rebased on nightly and signed the cla. I still don't know exactly why this fixes the error, but hopefully it's useful.

@jhgarner jhgarner marked this pull request as ready for review January 1, 2023 22:34
@ReenigneArcher
Copy link
Member

Rebased on nightly and signed the cla. I still don't know exactly why this fixes the error, but hopefully it's useful.

Thank you! The Windows error is not related to this change. All our builds are failing right now with that.

@ReenigneArcher ReenigneArcher force-pushed the wayland-nvidia-fix branch 2 times, most recently from afe27cc to cc481c0 Compare January 3, 2023 21:09
@ReenigneArcher ReenigneArcher merged commit ff88305 into LizardByte:nightly Jan 4, 2023
This was referenced Jan 23, 2023
Merged
Closed
@himekifee himekifee mentioned this pull request Feb 3, 2023
Merged
11 tasks
kelvie added a commit to kelvie/Sunshine that referenced this pull request Jan 24, 2024
@kelvie
Revert "Remove useless texture size queries for every frame in displa…
efb5939 
…y_ram_t"

This reverts commit ebe01ce.

Looks like this commit undos the fix for LizardByte#649, in PR LizardByte#884.
@kelvie kelvie mentioned this pull request Jan 24, 2024
Merged
11 tasks
kelvie added a commit to kelvie/Sunshine that referenced this pull request Jan 25, 2024
@kelvie
Revert "Remove useless texture size queries for every frame in displa…
2cbb44c 
…y_ram_t"

This reverts commit ebe01ce.

Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884.

This also adds a comment so hopefully it doesn't get removed again in
the future (or a proper fix is found).
kelvie added a commit to kelvie/Sunshine that referenced this pull request Jan 26, 2024
@kelvie
Revert "Remove useless texture size queries for every frame in displa…
ff7604c 
…y_ram_t"

This reverts commit ebe01ce.

Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884.

This also adds a comment so hopefully it doesn't get removed again in
the future (or a proper fix is found).
cgutman pushed a commit that referenced this pull request Jan 26, 2024
@kelvie @cgutman
Revert "Remove useless texture size queries for every frame in displa…
3f31400 
…y_ram_t"

This reverts commit ebe01ce.

Looks like this commit undos the fix for #453, see also PRs #649 and #884.

This also adds a comment so hopefully it doesn't get removed again in
the future (or a proper fix is found).
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
@kelvie
Revert "Remove useless texture size queries for every frame in displa…
28df670 
…y_ram_t"

This reverts commit ebe01ce.

Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884.

This also adds a comment so hopefully it doesn't get removed again in
the future (or a proper fix is found).
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
@kelvie @e-dong
Revert "Remove useless texture size queries for every frame in displa…
bf401eb 
…y_ram_t"

This reverts commit ebe01ce.

Looks like this commit undos the fix for LizardByte#453, see also PRs LizardByte#649 and LizardByte#884.

This also adds a comment so hopefully it doesn't get removed again in
the future (or a proper fix is found).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhgarner @CLAassistant @ReenigneArcher