Skip to content

CMake: Linux: use standard FreeDesktop udev/systemd paths #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

CMake: Linux: use standard FreeDesktop udev/systemd paths #550

merged 1 commit into from
Dec 14, 2022

Conversation

psyke83
Copy link
Contributor

@psyke83 psyke83 commented Dec 13, 2022 •
edited
Loading

Description

The multiarch path (e.g. /usr/lib/x86_64-linux-gnu) is not the correct path for these files.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@psyke83
Copy link
Contributor Author

psyke83 commented Dec 13, 2022

Added an extra commit to install a properly working udev rule. The issue is only reproducible if Steam is not installed, as it installs a working udev rule that overrided/added to the previous version of our rule.

@psyke83 psyke83 force-pushed the freedesktop_path_fix branch from eddde3e to 4b593b2 Compare December 13, 2022 18:40
ReenigneArcher
ReenigneArcher reviewed Dec 13, 2022
View reviewed changes
@psyke83 psyke83 force-pushed the freedesktop_path_fix branch from 4b593b2 to e9d5f00 Compare December 13, 2022 22:15
@psyke83
CMake: Linux: use standard FreeDesktop udev/systemd paths
62d1b22 
The multiarch path (e.g. /usr/lib/x86_64-linux-gnu) is not the correct path for these files.
@psyke83 psyke83 force-pushed the freedesktop_path_fix branch from e9d5f00 to 62d1b22 Compare December 13, 2022 22:52
@ReenigneArcher ReenigneArcher merged commit 37c0f79 into LizardByte:nightly Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sunshine-stack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psyke83 @ReenigneArcher