Skip to content

CMake: win32: fix linker errors with mingw boost 1.80.0-2 #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2022
Merged

CMake: win32: fix linker errors with mingw boost 1.80.0-2 #530

merged 2 commits into from
Dec 10, 2022

Conversation

psyke83
Copy link
Contributor

@psyke83 psyke83 commented Dec 7, 2022

Description

Fix linker errors seen with mingw-w64-x86_64-boost 1.80.0-2.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@psyke83 psyke83 force-pushed the restrict_boost_ver branch 2 times, most recently from 00ea146 to 40e815a Compare December 7, 2022 04:42
@psyke83 psyke83 force-pushed the restrict_boost_ver branch from b0c4d81 to 7648496 Compare December 8, 2022 14:57
@ReenigneArcher
Copy link
Member

ReenigneArcher commented Dec 10, 2022 •
edited
Loading

Do you mind bringing in my change from #524 here as well? That will allow me to merge both without adjusting branch protection rules.

Or I can bring your changes into that PR. Whatever you prefer.

@ReenigneArcher ReenigneArcher merged commit ed5ee24 into LizardByte:nightly Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sunshine-stack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psyke83 @ReenigneArcher