Skip to content

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Nov 28, 2022

Description

This PR changes the Simple-Web-Server submodule to the upstream actively maintained version. It turns out that all functionality that was specific to our fork was either implemented upstream or could be achieved without modifying the Simple-Web-Server code itself (by creating a class derived from SimpleWeb::Server<HTTPS>).

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman
Copy link
Collaborator Author

cgutman commented Nov 28, 2022

Looks like Simple-Web-Server doesn't currently build with the version of Asio included in Boost 1.71. I have submitted a MR to fix it: https://gitlab.com/eidheim/Simple-Web-Server/-/merge_requests/268

Once that is merged (or another fix is committed), I'll update the submodule again and that should fix the build break on those couple broken jobs.

@ReenigneArcher ReenigneArcher marked this pull request as draft November 28, 2022 02:33
@cgutman cgutman force-pushed the upstream_http_server branch from c305250 to f74a144 Compare November 30, 2022 00:16
@cgutman cgutman marked this pull request as ready for review November 30, 2022 00:16
@ReenigneArcher ReenigneArcher merged commit 5e6a42a into LizardByte:nightly Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants