Skip to content

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Nov 27, 2022

Description

Sunshine currently sends a hardcoded frame header with an invalid frame type value (0x104) that moonlight-common-c knows to ignore (otherwise it asserts on unknown frame types). Most of the frame header is unknown, but send a valid frame type value now that we understand that part of the header (and moonlight-common-c uses it for reference frame invalidation handling).

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@psyke83 psyke83 mentioned this pull request Nov 30, 2022
9 tasks
@ReenigneArcher ReenigneArcher merged commit 66f46ab into LizardByte:nightly Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants