Skip to content

Avoid using functions deprecated in OpenSSL 3.0 #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2022
Merged

Avoid using functions deprecated in OpenSSL 3.0 #515

merged 2 commits into from
Dec 16, 2022

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Nov 27, 2022 •
edited
Loading

Description

This PR fixes deprecation warnings in crypto.cpp due to use of legacy low-level SHA256/RSA APIs. I have replaced these with the high-level EVP equivalents as suggested by the OpenSSL 3.0 migration guide.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman
Copy link
Collaborator Author

cgutman commented Nov 27, 2022

There are still deprecated functions in use in the Simple-Web-Server submodule. If you fork that into the LizardByte org, I can submit a PR to fix those too.

@ReenigneArcher
Copy link
Member

Should we try to use the original Simple Web Server instead of trying to maintain a fork? It seems to still be actively developed. https://gitlab.com/eidheim/Simple-Web-Server

I've also forked Loki's fork, here: https://github.com/LizardByte/Sunshine-Simple-Web-Server

@cgutman
Copy link
Collaborator Author

cgutman commented Nov 27, 2022

It looks like some of the things we needed to patch in (like local endpoint address info) are now available upstream.

We may still need some out-of-tree patches, but we should at least rebase our fork on upstream. I'll play with the upstream repo and see what it takes to make it usable for us.

@ReenigneArcher
Copy link
Member

Perhaps change the submodule to point to upstream, and then we can apply any required patches similar to this (https://github.com/LizardByte/build-deps/pull/18/files) where needed?

@cgutman
Copy link
Collaborator Author

cgutman commented Nov 28, 2022

It turns out that we can actually migrate to the upstream version without needing any patches. See #517.

@ReenigneArcher ReenigneArcher merged commit f4edce3 into LizardByte:nightly Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sunshine-stack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgutman @ReenigneArcher