Skip to content

AMD encoder improvements #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2022
Merged

AMD encoder improvements #480

merged 1 commit into from
Dec 15, 2022

Conversation

psyke83
Copy link
Contributor

@psyke83 psyke83 commented Nov 7, 2022 •
edited
Loading

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@psyke83 psyke83 marked this pull request as draft November 7, 2022 04:16
@psyke83 psyke83 marked this pull request as ready for review November 7, 2022 04:34
@psyke83 psyke83 force-pushed the amf_improvements branch 3 times, most recently from 77235c7 to ecc37ba Compare November 9, 2022 16:43
@psyke83 psyke83 marked this pull request as draft November 30, 2022 04:12
@psyke83 psyke83 marked this pull request as ready for review November 30, 2022 04:19
@psyke83 @ReenigneArcher
video: amdvce: set better ffmpeg encoder options
6362f49 
* reorder options alphabetically
* set gops_per_idr to 1. Ref: https://trac.ffmpeg.org/ticket/7272
* qp_min/qp_max set by ffmpeg is suboptimal for the AMF encoder. Changing to
  the correct values greatly increases visual quality.
  Ref: GPUOpen-LibrariesAndSDKs/AMF#256 (comment)
* Enforce HRD to ensure that bitrate/maxrate is correctly constrained
* Enable VBAQ to improve visual quality in complex scenes (movement/foliage)
@ReenigneArcher ReenigneArcher merged commit a4a5d30 into LizardByte:nightly Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sunshine-stack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psyke83 @CLAassistant @ReenigneArcher