Skip to content

style(sonar): fix cpp:S6185 #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

style(sonar): fix cpp:S6185 #4133

merged 1 commit into from
Aug 8, 2025

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Aug 6, 2025 •
edited
Loading

Description

Fix sonar cpp:S6185 issues.

This change requires dropping support for macOS-13 as std::format requires xcode 15.3 or newer. This is not available for macOS-13. Since it will be EOL in October 2025, this seems fine to me. See: https://developer.apple.com/xcode/cpp/#c++20

TODO:

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the style/sonar/fix-cpp-S6185 branch from eff689d to 09e6f87 Compare August 6, 2025 04:00
@ReenigneArcher ReenigneArcher added this to the sonar milestone Aug 6, 2025
@ReenigneArcher ReenigneArcher marked this pull request as ready for review August 6, 2025 04:03
@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025

Bundle Report

Bundle size has no change ✅

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.36%. Comparing base (a28c20d) to head (15acac5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nvhttp.cpp 0.00% 13 Missing ⚠️
src/entry_handler.cpp 0.00% 3 Missing and 1 partial ⚠️
src/confighttp.cpp 0.00% 2 Missing ⚠️
src/nvenc/nvenc_base.cpp 0.00% 2 Missing ⚠️
src/platform/windows/audio.cpp 0.00% 2 Missing ⚠️
src/platform/linux/vaapi.cpp 0.00% 1 Missing ⚠️
src/rtsp.cpp 0.00% 1 Missing ⚠️
src/system_tray.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4133      +/-   ##
==========================================
- Coverage   11.37%   11.36%   -0.01%     
==========================================
  Files          92       92              
  Lines       17559    17568       +9     
  Branches     8063     8070       +7     
==========================================
  Hits         1997     1997              
+ Misses      14854    14709     -145     
- Partials      708      862     +154
Flag Coverage Δ
Linux-AppImage 11.58% <0.00%> (-0.01%) ⬇️
Windows-AMD64 12.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/vaapi.cpp 2.36% <0.00%> (ø)
src/rtsp.cpp 1.04% <0.00%> (ø)
src/system_tray.cpp 0.00% <0.00%> (ø)
src/confighttp.cpp 0.00% <0.00%> (ø)
src/nvenc/nvenc_base.cpp 0.00% <0.00%> (ø)
src/platform/windows/audio.cpp 25.32% <0.00%> (+0.04%) ⬆️
src/entry_handler.cpp 1.72% <0.00%> (+0.01%) ⬆️
src/nvhttp.cpp 18.10% <0.00%> (-0.27%) ⬇️

... and 18 files with indirect coverage changes

@ReenigneArcher ReenigneArcher mentioned this pull request Aug 6, 2025
Merged
22 tasks
@ReenigneArcher ReenigneArcher force-pushed the style/sonar/fix-cpp-S6185 branch 6 times, most recently from 58e35f9 to c73a051 Compare August 8, 2025 02:13
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher force-pushed the style/sonar/fix-cpp-S6185 branch from c73a051 to 15acac5 Compare August 8, 2025 02:43
@ReenigneArcher ReenigneArcher merged commit dbe80d0 into master Aug 8, 2025
43 of 44 checks passed
@ReenigneArcher ReenigneArcher deleted the style/sonar/fix-cpp-S6185 branch August 8, 2025 03:17
@ReenigneArcher ReenigneArcher mentioned this pull request Aug 15, 2025
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sonar
Development

Successfully merging this pull request may close these issues.
1 participant
@ReenigneArcher