Skip to content

ci: use actionlint and problem matchers #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

ci: use actionlint and problem matchers #4116

merged 1 commit into from
Jul 30, 2025

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jul 27, 2025 •
edited
Loading

Description

actionlint and problem matchers are being added in LizardByte/.github#488

This PR tests several of the problem matchers, and will update the workflows to pass the actionlint step.

Confirmed the following problems matchers are working:

  • gcc (Windows, AppImage)
  • gcc-strip3 (Homebrew, Flatpak)
  • docker
  • copr-ci (fedora copr build)
  • rpmlint (from copr-ci)
  • actionlint (from .github)
  • clang-format (from .github)
  • cmake-lint (from .github)
  • flake8 (from .github)
  • hadolint (from .github)
  • shellcheck (from .github)
  • yamllint (from .github)

TODO:

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov Codecov
Copy link

codecov bot commented Jul 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@4bac84e). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #4116   +/-   ##
=========================================
  Coverage          ?   11.32%           
=========================================
  Files             ?       92           
  Lines             ?    17570           
  Branches          ?     8238           
=========================================
  Hits              ?     1989           
  Misses            ?    13063           
  Partials          ?     2518
Flag Coverage Δ
Linux-AppImage 11.02% <ø> (?)
Windows-AMD64 12.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the ci/actionlint-and-problem-matchers branch 29 times, most recently from b472bb0 to 875d33d Compare July 29, 2025 15:16
@ReenigneArcher ReenigneArcher force-pushed the ci/actionlint-and-problem-matchers branch 2 times, most recently from 834ff18 to 3330a3a Compare July 30, 2025 00:11
@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 30, 2025 00:16
@ReenigneArcher ReenigneArcher force-pushed the ci/actionlint-and-problem-matchers branch 4 times, most recently from 8059e9d to 92c6ba6 Compare July 30, 2025 01:08
@ReenigneArcher ReenigneArcher force-pushed the ci/actionlint-and-problem-matchers branch from 92c6ba6 to 94a2a59 Compare July 30, 2025 01:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher merged commit 99cf9ac into master Jul 30, 2025
47 checks passed
@ReenigneArcher ReenigneArcher deleted the ci/actionlint-and-problem-matchers branch July 30, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ReenigneArcher