fix(video): restore the ability to set a minimum fps target #4114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e user-friendly wording
d7e4028 to
59c69db
Compare
|
10 tasks
Bundle ReportChanges will increase total bundle size by 706 bytes (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4114 +/- ##
==========================================
- Coverage 11.32% 11.31% -0.01%
==========================================
Files 92 92
Lines 17570 17572 +2
Branches 8238 8240 +2
==========================================
Hits 1989 1989
- Misses 14900 14902 +2
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges the current minimum FPS behavior with the old min_fps_factor, under a new name minimum_fps_target. It defaults to 0 (current "about half the stream FPS") and can be set to any value from 1-1000. (Note: input validation appears to be broken, but is out of scope for this fix.)
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage