Skip to content

build(linux): linux_build.sh fixes (gcc/doxygen) #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

gschintgen
Copy link
Contributor

@gschintgen gschintgen commented Jul 20, 2025

Description

I noticed two places in linux_build.sh that missed a sudo in order to actually work if used by an unprivileged user:

  • when setting up gcc
  • when locally compiling (and installing!) doxygen.

Additionally, the script will now pushd into the build directory before compiling doxygen, and popd out when finished.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Copy link

Copy link

codecov bot commented Jul 21, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.32%. Comparing base (a19312b) to head (6be51f1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4098   +/-   ##
=======================================
  Coverage   11.32%   11.32%           
=======================================
  Files          92       92           
  Lines       17570    17570           
  Branches     8238     8238           
=======================================
  Hits         1989     1989           
  Misses      13063    13063           
  Partials     2518     2518           
Flag Coverage Δ
Linux-AppImage 11.02% <ø> (ø)
Windows-AMD64 12.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher merged commit bce4b1b into LizardByte:master Jul 21, 2025
79 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants