fix(windows): bundle vigembus instead of downloading it #4088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f50bf3 to
5b4fbb8
Compare
Bundle ReportChanges will increase total bundle size by 675 bytes (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4088 +/- ##
=========================================
Coverage 11.31% 11.31%
=========================================
Files 92 92
Lines 17571 17571
Branches 8239 8239
=========================================
Hits 1989 1989
+ Misses 14901 13063 -1838
- Partials 681 2519 +1838
Flags with carried forward coverage won't be shown. Click here to find out more. |
5b4fbb8 to
7f3d84c
Compare
|
|
For reference the current pre-release (1725da2) virustotal results: https://www.virustotal.com/gui/file/9b08ede8f411e27d7acb065e65efd901be9335ab33911ded6c7251578a33f6d4?nocache=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts how vigembus is installed in the Windows installer.
This should solve at least 3 of the 4 items mentioned #3962 (comment), though I am not 100% sure of the 4th item.
Note this bundles the second to latest release of vigembus, as the absolute latest one has one flag in virustotal: LizardByte/roadmap#89
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist