Skip to content

fix(display): Restore Checkbox import for display device opts #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

VMFortress
Copy link
Contributor

Description

As discussed in #3613, the import for the Checkbox element was removed as a part of #3579 which stopped the 'Config revert on disconnect', option in the display options, from rendering.

This simply adds the import back which restores the functionality.

Screenshot

Before (v2025.628.4510):
sunshine_before
After:
sunshine_after

Issues Fixed or Closed

None

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the fix/display/config_revert_on_disconnect_missing branch from 7a83afe to 2fca74a Compare July 14, 2025 20:55
Copy link

Copy link

codecov bot commented Jul 14, 2025

Bundle Report

Changes will decrease total bundle size by 40 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 1.74MB -40 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/config-*.js -45 bytes 57.33kB -0.08%
assets/Checkbox-*.js 5 bytes 2.11kB 0.24%

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.31%. Comparing base (4478fd2) to head (2fca74a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #4076     +/-   ##
=========================================
  Coverage   11.31%   11.31%             
=========================================
  Files          92       92             
  Lines       17571    17571             
  Branches     8239     8239             
=========================================
  Hits         1989     1989             
- Misses      13063    14901   +1838     
+ Partials     2519      681   -1838     
Flag Coverage Δ
Linux-AppImage 11.02% <ø> (ø)
Windows-AMD64 12.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit fe26129 into LizardByte:master Jul 14, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants