Skip to content

Conversation

Alexis-BX
Copy link
Contributor

@Alexis-BX Alexis-BX commented Aug 3, 2025

Alexis-BX Medium Alexis-BX /Fix-Oidc-user-islogin-and-admin → Lissy93/dashy Commits: 1 | Files Changed: 6 | Additions: 52 Label Powered by Pull Request Badge

Category:

One of: Bugfix / Feature

Overview

Bugfix: fixed the behaviour of getUsers and isLoggedIn to support users logged in via OIDC

Feature: added a adminRole and adminGroup that can be used to create a mapping from an OIDC group or role to Dashy admins

Issue Number (if applicable) #1893 #1823

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here

appConfig.auth.oidc

Field Type Required Description
adminRole string Optional The role that will be considered as admin.
adminGroup string Optional The group that will be considered as admin.

localStorageKeys.ISADMIN which is used for OIDC to pass the user admin status to getUsers (from @/utils/Auth) who can then handle it like any other user

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@Alexis-BX Alexis-BX requested a review from Lissy93 as a code owner August 3, 2025 07:19
Copy link

netlify bot commented Aug 3, 2025

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit ac13e54
🔍 Latest deploy log https://app.netlify.com/projects/dashy-dev/deploys/688f0d94a7469b00080b8cc1
😎 Deploy Preview https://deploy-preview-1894--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Lissy93 Lissy93 merged commit 4e00947 into Lissy93:master Aug 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants