fix: Update golang.org/x/tools to v0.34.0 for Go 1.25 compatibility #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build error with Go 1.25 manifests as: go1.25rc1 build ./... # golang.org/x/tools/internal/tokeninternal ../../../go/pkg/mod/golang.org/x/tools@v0.13.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64) go1.25rc1 get -u golang.org/x/tools go: upgraded go 1.19 => 1.23.0 go: upgraded golang.org/x/crypto v0.21.0 => v0.39.0 go: upgraded golang.org/x/mod v0.12.0 => v0.25.0 go: upgraded golang.org/x/net v0.23.0 => v0.41.0 go: upgraded golang.org/x/sync v0.3.0 => v0.15.0 go: upgraded golang.org/x/sys v0.20.0 => v0.33.0 go: upgraded golang.org/x/term v0.18.0 => v0.32.0 go: upgraded golang.org/x/text v0.14.0 => v0.26.0 go: upgraded golang.org/x/tools v0.13.0 => v0.34.0 go1.25rc1 mod tidy Related: * Go proposal: golang/go#73205 * Upstream `golang.org/x/tools` fix: https://go-review.googlesource.com/c/tools/+/675955 / golang/tools@2815c8b * Problem found in Homebrew/homebrew-core#226636
62 tasks
|
Workflows tested in my fork: |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed?
Fixes build with Go 1.25 (currently at rc1, final expected in August)
The build error with Go 1.25 manifested as:
Updated via
Updated Go to supported version 1.24.
Updated linter to current one supporting Go 1.24 and fixed linter warnings.
Is this PR related to an existing issue?
Related:
golang.org/x/toolsfix: https://go-review.googlesource.com/c/tools/+/675955 / golang/tools@2815c8bCheck off the following: