Skip to content

feat: add Venmic module for screensharing #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Conversation

KarboXXX
Copy link
Contributor

  • added Venmic support for audio screensharing for specific applications like suggested on Audio screensharing for an individual window/the selected window #782
  • added Venmic settings in settings page
  • removed bitrate settings from default settings and settings page
  • addded verification for missing configuration keys in settings.json
  • added audio entry as object in settings, instead of string (better manage Venmic audio settings instead just of changing loopback type)
  • added Venmic sound dropdown option in screenshare dialog for selecting Venmic audio input

@smartfrigde smartfrigde merged commit 7118ef0 into Legcord:dev Jan 26, 2025
1 check passed
@smartfrigde smartfrigde changed the title added Venmic module for screensharing feat: add Venmic module for screensharing Jan 26, 2025
@fabricionaweb
Copy link
Contributor

Hi, does the tsx needs to be under dependencies? Can it be under devDependencies? It is increasing bundle size significantly due the esbuild binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants