Skip to content

fix: git describe fallback with no tag #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: git describe fallback with no tag #34

merged 1 commit into from
Feb 5, 2024

Conversation

LecrisUT
Copy link
Owner

@LecrisUT LecrisUT commented Feb 5, 2024

Closes #32

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

Test Results

 3 files  ±0   3 suites  ±0   2m 35s ⏱️ +7s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
18 runs  ±0  18 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8fa4260. ± Comparison against base commit eac47a4.

♻️ This comment has been updated with latest results.

@LecrisUT
Fix git describe fallback with no tag
8fa4260 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT force-pushed the fix/git-no-tag-fallback branch from fe3a88b to 8fa4260 Compare February 5, 2024 11:24
@LecrisUT LecrisUT merged commit d412a6a into main Feb 5, 2024
@LecrisUT LecrisUT deleted the fix/git-no-tag-fallback branch February 5, 2024 12:41
@LecrisUT LecrisUT added the bug Something isn't working label Feb 5, 2024
@LecrisUT LecrisUT mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DynamicVersion fails with FALLBACK_VERSION + git
1 participant
@LecrisUT