-
Notifications
You must be signed in to change notification settings - Fork 19
Use rustls-tls
instead of OpenSSL
#62
Conversation
Huh. I wonder why the 1.58 test suite has started failing, I noticed that on main too. |
I bumped the MSRV on the main branch to 1.60.0. If you rebase or pull main, it'll rerun the test suite and we'll see. |
Done! |
Oh it failed again, looks like reqwest |
Feel free to bump the MSRV in the workflow file until it does work 😅 |
Succeeded with |
It looks like You can compare this PR to jackTabsCode/asphalt#37 to see the difference. |
It is actually not necessary to make Linux builds succeed but that's definitely better as we have less dependencies. |
Right, not necessary to make the builds succeed, but it is necessary to ensure the binaries can run on machines that don't have a compatible version of OpenSSL installed. Otherwise, users would download and run the binary on those machines and find that they fail with a load-time error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merging when CI finishes.
Closes #61