Haiku build fix. #5694
Merged
Haiku build fix. #5694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Little question. If there any plan to update rpmalloc (ie its current git hash is old and sets wrongly tls model, thus the runtime_loader fails to resolve when it starts but it had been solved since) ? |
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://9155-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-717%2Bgbfcb68f-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9155?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://9154-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-717%2Bgbfcb68feb-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9154?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://9157-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-717%2Bgbfcb68feb-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9157?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/7g09vdwd3ylr1imp/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35529657"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/mc028fhus0tu6uce/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35529657"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://9158-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-717%2Bgbfcb68feb-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9158?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "b0f7ba5b91ab3bf9f2164beb1b6dbd494599d898"} |
related to ringbuffer, matching cmake settings to disable mlock for this platform. Haiku does not support tls model as well.
|
Right but isn't Ubuntu 14.04 EOL ? Anyway yes in that case the compiler toolchain might be old for newer rpmalloc. Yes indeed I changed locally to make it work :-) |
JohannesLorenz
approved these changes
Oct 4, 2020
There was a problem hiding this comment.
Looks all good. I'll merge this now. The rpmalloc fix will remain delayed until #5696 is done.
JohannesLorenz
added a commit
that referenced
this pull request
Oct 5, 2020
|
@devnexen for your info, rpmalloc is updated on master now. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to ringbuffer, matching cmake settings to disable mlock for this platform.
Haiku does not support tls model as well.