Skip to content

MIDI import/export: map note volume and MIDI velocity with their full range #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2019
Merged

MIDI import/export: map note volume and MIDI velocity with their full range #4785

merged 2 commits into from
Jan 21, 2019

Conversation

PhysSong
Copy link
Member

Fixes #4761.

zonkmachine
zonkmachine approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@zonkmachine zonkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Repeated imports/export/import... etc., of a demo project, will create identical exported midi files and identical imported mmps. Volume <-> velocity is correct.

@zonkmachine
Copy link
Contributor

I'm going to just go ahead and merge.

@zonkmachine zonkmachine merged commit c1ae1ed into LMMS:stable-1.2 Jan 21, 2019
@jasp00
Copy link
Member

jasp00 commented Jan 21, 2019

According to MIDI 1.0 specification, which might be this one, velocity is not strictly defined, but it should follow a logarithmic scale. I guess velocity = 64 should mean 100% in LMMS.

@zonkmachine
Copy link
Contributor

velocity is not strictly defined

Correct. It's basically just info about how fast a key is struck.

I guess velocity = 64 should mean 100% in LMMS.

And it is. (had to double check...)

@jasp00
Copy link
Member

jasp00 commented Jan 21, 2019

Sure, 100% is 64. I was suggesting to consider a logarithmic scale instead of a linear one.

@jasp00
Copy link
Member

jasp00 commented Jan 21, 2019

Should we use the algorithm from our favorite free MIDI player?

@PhysSong PhysSong deleted the midiimexvel branch April 29, 2019 01:10
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@PhysSong @zonkmachine
MIDI import/export: map note volume and MIDI velocity with their full…
7423b62 
… range (LMMS#4785)

* MIDI export: map volume to MIDI velocity correctly

* MIDI import: map MIDI velocity to note volume with full range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zonkmachine zonkmachine zonkmachine approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhysSong @zonkmachine @jasp00