Skip to content

Conversation

WalterSmuts
Copy link
Contributor

This is in reference to #2688. This is however not complete since the Automation editor also needs to be Anti-Aliased and there is still a bug:

The graph/pattern is not being drawn in certain circumstances. It seems to be when it isn't referencing anything but still has a set of data points. The picture below shows the pattern in the editor and right above it it can be seen to not be displaying in the PatternView.
auto

PS: (Please let me know if I'm doing anything in the wrong way. Submitting issues, pull requests etc. This is the first time trying to)

@WalterSmuts
Copy link
Contributor Author

Should I have posted this before the bug I mentioned has been fixed? I'm not sure if the workflow works so that I need to be 100% confident in a pull request or that it's still acceptable to post a pull request with known errors as a work in progress?

@zonkmachine
Copy link
Contributor

... or that it's still acceptable to post a pull request with known errors as a work in progress?

This. Now you can get feedback and we know what is being worked on.

@RebeccaDeField RebeccaDeField changed the title Fixes Ailiasing in AutomationPatternView [WIP] Fixes Ailiasing in AutomationPatternView Feb 26, 2017
@WalterSmuts
Copy link
Contributor Author

I think I'm closing this pull request because I requested to merge with my master branch which makes it harder to work with on my side... So I created a separate branch on my forked repository and I will create another pull request from that branch... (I don't think there is a way to change this pull request to a different branch on my forked repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants