-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
waveshaper redesign #3097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waveshaper redesign #3097
Conversation
@m-xbutterfly I really like what you've done here. A couple of ideas...
|
Sorry for accidentally closing this. Was trying to add a comment on my phone and I clicked the wrong button. Reopened :) |
@m-xbutterfly Are you going to be redesigning the Dynamics Processor as well? |
@m-xbutterfly Thanks for the update! I'm thinking that a folder will be created for people to add their sources for the new plugin designs. I am planning on making a pr with a bit more organization for the new theme in the artwork repo so I'll let you once that is done. I'll leave the Dynamics Processor open for now so if you want to take that on, please update me on the plugins thread, and if not no problem :) |
@m-xbutterfly this looks very nice to me. Would you be open to dimming the green down in the grid and changing the light blue slanted line to a brighter contrastng green? Thank you for collaborating with me on this :) |
Oh it's no problem at all. I just work a lot so I might be slow to make these changes. Anyways I tried a couple different greens for the slanted blue line. I'm not sure if either of these work (I prefer the second one). I'm trying to pick colors from elsewhere in the project (or change the hue from the old one) to be consistent. I also dimmed down the green a bit, and changed the background to gray. I just took those colors from your example. Also just so you see it now here's what it looks like with the cursor down. Do you want me to change the color? |
The "-1dB" and the "+1dB" string should be aligned. |
@m-xbutterfly Quick mockup idea: I tweaked the hue of the green in the diagonal line to #55cc91 and changed the cursor grid to #707c91. What do you think? |
@RebeccaDeField Your mockup looks good to me... a method that I usually use is swinging my laptop around at different angles to view new graphics, and this is really noticeable from almost any angle. |
I have a color palette in my source files. As long as people only alter the lightness and not change the hue or saturation, it will fit well within the theme.
I have a guide written up here to insure that all of the plugins can match nicely. Right now I am collaborating all of the plugins to make sure they follow the style guide.
Glad to hear it :) |
Here's a few options. I wasn't really sure which one was best: I also tried to use the orbitron font which is used pretty heavily in the svg files but it didn't end up looking good imo. The option is still there though: That is a screenshot btw. Here it is with the cursor grid: Let me know if there's anything else you want me to tweak. Thanks. |
@m-xbutterfly Are you using Inkscape to design this? If so, you might want to make sure that you're exporting the buttons using the Cairo option, as this will insure that the text is crisp. You can do this by saving a copy of the button and selecting the Cairo option in the list. I mostly use Orbitron for bolder headings, so I agree with you that it does not translate as well for small buttons. In terms of alignment, I would like to ask @BaraMGB what his preference is, since he added a comment about it. |
I would like to see the alignment of the "+1dB" and the "-1dB" string on the right. So the most chars are aligned horizontal. The problem here is that the width of the "-" char is smaller than the width of the "+" char. So it looks odd to me. |
@BaraMGB @m-xbutterfly I believe this can be easily accomplished by turning the text to path and widening the minus symbol. |
Here they are right aligned. @BaraMGB What if I used a fixed-width font like monospace? The "+" and "-" are still not perfectly aligned but they used up the same space so it looks much nicer imo. Thanks for the advice @RebeccaDeField. I've been using export PNG image because that saves it with a transparent background. I don't think that has a cairo option though. Using "save as.." and the cairo options saves it with a white background but it's really easy to remove. Both of those previews are using the cairo option. EDIT: I just read your comment about widening the path. I can try it but it's hard to figure how the svg in inkscape translates to a png. I have the text on different layers and this is what it looks like when both the -1dB and +1dB layers are visible. |
@m-xbutterfly I would suggest lining up white layer so that "1dB" lines up perfectly with the right edge of the green "1dB" text you are seeing underneath that layer. Then convert the text to path and extend the the minus character to come to the left edge of the plus character underneath. I hope this makes sense. If you are having some difficulties and would like me to play around with the svg, I would be more than willing to :) |
Here are the svg files. I made it so I could just hide/show different layers and then save the button as a png. I'm more of a programmer than designer so I'd appreciate the help. |
I'm more of a designer than a programmer. Good team, right? I tweaked the text and buttons a bit and I think as long as they are exported with Cairo, it should look as you intended and have the alignment that Bara wanted. Feel free to make any edits that you might want to the file I attached :) |
👍 |
The knobs look like they could be moved down and left, imo. Maybe spaced
out a bit as well since there's so much free soace near the middle.
|
I agree with @Spekular, but otherwise the plugin design looks good to me 👍 |
Sorry about taking so long. I'll have more time this weekend to work on this. How does that look? The way it was before, the knobs were the same distance from the border as the buttons. I have the knobs (plus the text) vertically aligned with the controls background. I moved them a few pixels to the left. How do you feel about the controls background being slightly wider than the graph? It's 3 pixels on either side, so the graph is centered to it. I'm not sure if it's a problem. BTW, thanks for your help @RebeccaDeField with those buttons. |
I don't have a problem with it per se, but is there a specific reason why it's wider? I do feel like the knobs need a bit more space, just to feel balanced. I had a few ideas so I asked for opinions on Discord, and these were the two favorites. These are just mockups, so not perfect, but I hope that it communicates the concept well enough.
Absolutely. :) |
I don't know why it's wider actually. I didn't create an svg file so all I have is a png I made in gimp. The knobs are a little closer together. The reason is that multitap echo seems to have the widest distance between knobs and that's only 50px. I didn't want to go more than that. I also noticed that the background was moved a couple of pixels to the left so it looks assymetric, but I fixed that too. Is that preview ok? |
@m-xbutterfly That looks great to me 👍 |
I'm fine with that. |
Is the |
@Umcaruje Only difference is that I modified the M slightly because it was looking strange when exported with Cairo. Maybe we should just use a different font altogether. What do you think about this? EDIT: On second thought, I don't think this text is legible enough. It will be easier for me to make the text from-scratch than to find a font with the right licencing that looks good at 6px. |
@m-xbutterfly @Umcaruje Okay, what do you guys think about this? Please click on images for full resolution :) |
@m-xbutterfly Sorry, I forgot to mention that I changed the buttons to be 1px taller. I think the buttons are being scaled in your design, so they're not quite as crisp as in my comment.
I think that custom text should only be used in cases where the text is extremely small and especially hard to read. I created the text for the sends buttons, and other areas that needed to be very legible in a small space that could neither be jagged (like a typical pixel-font) or blurry. I'm not sure if this will cause problems in the future, but if someone knows another way to accomplish this with 6px I think it would be a good idea. |
@m-xbutterfly Please see attachment bellow. Now that the text is pixel-perfect, you can just use the regular Inkscape export dialog. Thank you for your patience on this :) |
@m-xbutterfly I like the 2nd option, where you centered the buttons and check box. @Umcaruje Are the buttons looking good to you in place? |
The buttons look good and consistent to me 👍 |
@m-xbutterfly If there are no objections after I test the PR, I will merge this 👍 |
Looks good to me. 👍 |
* waveshaper redesign * Correcting for inconsistency with overall theme * fix knobs and background * Changed buttons with more consistent font
What do you guys think of this waveshaper redesign wrt #2831?