Sample Tracks: FX Mixer Support #3632
Conversation
|
I'll try to work on it soon. @grejppi Please grant me push access when I request. |
|
@grejppi The work is almost done. I'll create a new PR or push commits into your branch(if you grant it) when finished. |
|
@PhysSong Great! 😊 Please open a pull request against my fork once you're done :3 |
|
Some new features are added now: I can toggle sample track windows with track label buttons, and windows now have proper title and are able to rename on it. |
|
@grejppi Your branch is out-of-date. Please update it. |
|
@PhysSong done |
|
Now it looks like this: |
|
@grejppi I opened a PR against your branch. Please test it. |
|
@PhysSong Sweet! I'll test it soon 😊 |
|
That works like a charm. Great work! |
|
@grejppi I forgot |
|
|
||
|
|
||
| class SampleTrackWindow : public QWidget, public ModelView, | ||
| public SerializingObjectHook |
There was a problem hiding this comment.
The indentation here looks weird, is it intentional?
| @@ -312,6 +313,22 @@ void FxMixer::deleteChannel( int index ) | |||
| inst->effectChannelModel()->setValue(val-1); | |||
| } | |||
| } | |||
| else if( t->type() == Track::SampleTrack ) | |||
| { | |||
| SampleTrack* strk = dynamic_cast<SampleTrack *>( t ); | |||
There was a problem hiding this comment.
The spaces in the brackets here are really inconsitent in the block, it's not a violation of the coding conventions, but it just looks weird.
| @@ -386,6 +403,19 @@ void FxMixer::moveChannelLeft( int index ) | |||
| inst->effectChannelModel()->setValue(a); | |||
| } | |||
| } | |||
| else if( trackList[i]->type() == Track::SampleTrack ) | |||
| { | |||
| /* | ||
| * FxLineLcdSpinBox.cpp - a specialization of LcdSpnBox for setting FX channels | ||
| * | ||
| * Copyright (c) 2004-2014 Tobias Doerffel <tobydox/at/users.sourceforge.net> |
There was a problem hiding this comment.
Either of your names should go in the copyright info here
There was a problem hiding this comment.
Just realised this is just moving the already existing code into a new file, so we could maybe just extend the copyright
| QPointer<CaptionMenu> contextMenu = new CaptionMenu(model()->displayName(), this); | ||
|
|
||
| if (QMenu *fxMenu = m_tv->createFxMenu( | ||
| tr("Assign to:"), tr( "New FX Channel" ))) |
|
They are in my commits. |
withdrawn