Skip to content

Conversation

karmux
Copy link
Contributor

@karmux karmux commented Apr 13, 2017

Copied from GIG Player. Opens correct SF2 plugin directory when running LMMS from build directory without install. Used to open LMMS build directory before.

… SF2 plugin directory when running LMMS from build directory without install.
Copy link
Member

@Umcaruje Umcaruje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the fix, just to explain, the problem occured when you had an already loaded soundfont, and the file dialog wouldn't open at its location, rather opened at the last browsed folder.

@Umcaruje
Copy link
Member

I think this fix should be targeted at stable-1.2.

@tresf
Copy link
Member

tresf commented Apr 14, 2017

just to explain, the problem occured when you had an already loaded soundfont, and the file dialog wouldn't open at its location, rather opened at the last browsed folder.

I think we have a few areas where this bug occurs (e.g. saving a project, opening a project). I find myself desiring this same behavior in other dialogs.

I can confirm the fix

Great we can merge.

I think this fix should be targeted at stable-1.2.

Agreed.

@tresf tresf changed the base branch from master to stable-1.2 April 14, 2017 13:00
@tresf tresf changed the base branch from stable-1.2 to master April 14, 2017 13:00
@tresf
Copy link
Member

tresf commented Apr 14, 2017

Well, changing the branch didn't do well. Perhaps we can cherry-pick back onto stable.

@Umcaruje
Copy link
Member

@tresf I think we should change the default branch to stable-1.2 on github. Also I think all future small fixes like this can be targeted to stable-1.2 with no problems @karmux

@tresf
Copy link
Member

tresf commented Apr 14, 2017

@tresf I think we should change the default branch to stable-1.2 on github. Also I think all future small fixes like this can be targeted to stable-1.2 with no problems @karmux

We did that for stable-1.0 as well since so many bugfixes were hitting it in a short period of time. I'll do that now however we should switch it back shortly after release.

@tresf
Copy link
Member

tresf commented Apr 14, 2017

I'll do that now

Done.

@tresf tresf merged commit fc70ae3 into LMMS:master Apr 15, 2017
tresf pushed a commit that referenced this pull request Apr 15, 2017
… SF2 plugin directory when running LMMS from build directory without install. (#3502)
@tresf
Copy link
Member

tresf commented Apr 15, 2017

Cherry-picked to stable-1.2 via 09c9ccb

@karmux karmux deleted the sf2_simpler_filedialog branch April 28, 2017 20:45
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
… SF2 plugin directory when running LMMS from build directory without install. (LMMS#3502)
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
… SF2 plugin directory when running LMMS from build directory without install. (LMMS#3502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants