Then can we switch to dynamic_cast? This code could be an unsafe cast if non-File events happen. Advice appreciated.

Edit: Never-mind, I see the new logic removes the possibility for fall-through. If we properly check the cast, it should be added back in.

Also, what's the problem with the code comment?

  // Fall through to default
- // Fall through to default

This is a safe-guard comment. Switch-cases that use selective fall-through can be hard to spot or flagged as mistakes when they are not. This comment was intentional.

Doh! Nevermind.... We're already testing the type implicitly with case QEvent::FileOpen:, thus removing the need for non-obvious/bad-cast fall-through. Merging.