Skip to content

Conversation

Umcaruje
Copy link
Member

Per #2978 and #2831

Screenshot:
screenshot from 2016-08-22 23 11 41

@RebeccaDeField

Removed the redundant "M" label next to the mute LED's. The LED behaviour was also reworked to match the rest of the software (Band is muted when the LED is off, same as the mixer).

@RebeccaDeField RebeccaDeField mentioned this pull request Aug 22, 2016
14 tasks
@Spekular
Copy link
Member

Spekular commented Aug 22, 2016 via email

@Umcaruje
Copy link
Member Author

Umcaruje commented Aug 22, 2016

The green on the handles is nice, but also seems to suggest "on". Do the
handles gray out when a band is muted?

No they don't. The green handles on the FX mixer don't grey out when a band is muted?

Maybe I could change the LED color to blue to avoid confusion.

@Spekular
Copy link
Member

You're right, I didn't think about that. It's probably fine.

@Umcaruje
Copy link
Member Author

screenshot from 2016-08-22 23 40 58

@Spekular is this better?

@Spekular
Copy link
Member

@Umcaruje I think the original is better, since the LEDs are consistent that way. Since the handles are the same style as the new mixer handles it's fine, I was thinking about the old mixer handles that were gray and thought that a mismatch there might be confusing.

@Umcaruje
Copy link
Member Author

@Spekular Yeah, I'm going to keep them green, to be consistent with the Mixer. Graying out the handles is probably an overkill.

@RebeccaDeField
Copy link
Contributor

RebeccaDeField commented Aug 25, 2016

@Umcaruje For some reason the box that wraps around the sliders and LEDs doesn't quite look right to me. I might be wrong, but it didn't look pixel perfect when I zoomed in and the borders and highlights seems a bit thicker than what I used elsewhere.

I went ahead and tweaked the Crossover EQ to what I felt matched the plugin BG a little more. Please see the file attached and of course, if you want to modify I will send over the source file :)

artwork

@Umcaruje
Copy link
Member Author

@RebeccaDeField thanks for the feedback, I just resized your graphics as a group, which was a bad idea. I rectreated the whole thing from scratch now, since it needed some tweaking. I also want to say that the faders are pixel perfect now too:
screenshot from 2016-08-26 00 41 24

@RebeccaDeField
Copy link
Contributor

@Umcaruje Looks better to me now 👍

@Umcaruje Umcaruje merged commit d2a5c49 into LMMS:master Aug 28, 2016
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* Redesign Crossover Equalizer

* Make it all pixel perfect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants