-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Redesign Crossover Equalizer #2994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The green on the handles is nice, but also seems to suggest "on". Do the
handles gray out when a band is muted?
|
No they don't. The green handles on the FX mixer don't grey out when a band is muted? Maybe I could change the LED color to blue to avoid confusion. |
You're right, I didn't think about that. It's probably fine. |
@Spekular is this better? |
@Umcaruje I think the original is better, since the LEDs are consistent that way. Since the handles are the same style as the new mixer handles it's fine, I was thinking about the old mixer handles that were gray and thought that a mismatch there might be confusing. |
@Spekular Yeah, I'm going to keep them green, to be consistent with the Mixer. Graying out the handles is probably an overkill. |
@Umcaruje For some reason the box that wraps around the sliders and LEDs doesn't quite look right to me. I might be wrong, but it didn't look pixel perfect when I zoomed in and the borders and highlights seems a bit thicker than what I used elsewhere. I went ahead and tweaked the Crossover EQ to what I felt matched the plugin BG a little more. Please see the file attached and of course, if you want to modify I will send over the source file :) |
3281e90
to
2d12d24
Compare
@RebeccaDeField thanks for the feedback, I just resized your graphics as a group, which was a bad idea. I rectreated the whole thing from scratch now, since it needed some tweaking. I also want to say that the faders are pixel perfect now too: |
@Umcaruje Looks better to me now 👍 |
2d12d24
to
1bc1ab2
Compare
* Redesign Crossover Equalizer * Make it all pixel perfect
Per #2978 and #2831
Screenshot:

@RebeccaDeField
Removed the redundant "M" label next to the mute LED's. The LED behaviour was also reworked to match the rest of the software (Band is muted when the LED is off, same as the mixer).