-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Redesign Spectrum Analyzer #2971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Those dimmed LEDs are difficult to see now. Is that due to the colors chosen for this plugin, or is that something new-theme related? |
@Umcaruje Great observation! I aligned the text to be the same distance from the top as the other plugin I designed, but I guess it might make more sense to center the title within the elements of each particular plugin. @tresf I believe that the plugin is coded in a way that dims the background, while leaving the graph/visualizer the same as the original graphic. This left my graphic a darker than I expected when I first put it in place. I brightened the colors to compensate, but I can absolutely bump the brightness up a notch if it's looking too dark on your computer. |
If we want a consistent design through all plugins, shouldn't the title in all plugins at the same place? In the controller the title is align to the left. And the background gots a specific gradient. Edit: we could put the dB readout to the right site to align all elements at left. |
@BaraMGB I did a quick search for other Spectrum Analyzers and it does seem that most put the db readout on the right (or both sides at once), but there are some that put it on the left. As long as we wouldn't be breaking any standards, I don't see any problem with changing the layout that way.
The background has the same gradient here that is used in the other plugins. 👍 |
Updated spectrum analyzer design based on feedback: @tresf I brightened the background colors and darkened the grid for more contrast as per your request :) @BaraMGB I was going to move the db readout, but ended up removing the titles so I didn't see a reason to move it anymore. Please let me know if you would still like it on the right instead :) |
I just noticed that the background needs to be tweaked. Will be updating that soon. |
@RebeccaDeField Of course the readout is fine on the left without the title. 👍 |
The LEDs look too dark in general. They disappear into the background. I don't think this is a problem with the background but rather something with the new theme itself. BEFORE vs. AFTER |
@tresf Just realized that I was thinking of the LED visualizer, but it seems you were actually referring to the Linear spectrum and Linear Y axis LEDs. If so, do you find that they are too dim throughout the whole theme or just on this plugin? I have solutions for both scenarios. |
Terrific question. Well, upon reexamination, the whole theme (albeit less noticeable of an issue when nearby LEDs are lit or when the LED is a two-state LED) So my LED contrast comments are off-topic to this post and should be tracked in a separate issue. |
@tresf I agree. It sounds like this is something separate from this particular plugin design. The darker leds were one of the first elements I designed so with all of the color changes I believe they no longer have enough contrast with the rest of the theme. Lightening (probably) or darkening them (maybe) should be the solution. Because this seems pretty straightforward to me, I think I will go ahead and make a PR for it and if that doesn't fix the issue, further discussion can continue there. :) |
Merging. |
* Redesign Spectrum Analyzer * Update Spectrum Analyzer * Update background
Updated screenshots of plugin design @Umcaruje @BaraMGB
Before:

After:

In this pull request I have: