Skip to content

Conversation

RebeccaDeField
Copy link
Contributor

@RebeccaDeField RebeccaDeField commented Aug 12, 2016

Updated screenshots of plugin design @Umcaruje @BaraMGB

Before:
spectrum_analyzer_1 0 0

After:
image

In this pull request I have:

  • Updated the fonts, colors and aesthetic to match new theme
  • Recreated grid, while remaining pixel perfect with exactly the same spacing as the previous grid

@Umcaruje
Copy link
Member

d7d11fd8-6034-11e6-982b-36970bc5773f

I feel the title should be moved 2 pixels down to be centered perfectly. Other than that, looking mint 👌

@tresf
Copy link
Member

tresf commented Aug 12, 2016

Those dimmed LEDs are difficult to see now. Is that due to the colors chosen for this plugin, or is that something new-theme related?

@RebeccaDeField
Copy link
Contributor Author

RebeccaDeField commented Aug 13, 2016

@Umcaruje Great observation! I aligned the text to be the same distance from the top as the other plugin I designed, but I guess it might make more sense to center the title within the elements of each particular plugin.

@tresf I believe that the plugin is coded in a way that dims the background, while leaving the graph/visualizer the same as the original graphic. This left my graphic a darker than I expected when I first put it in place. I brightened the colors to compensate, but I can absolutely bump the brightness up a notch if it's looking too dark on your computer.

@BaraMGB
Copy link
Contributor

BaraMGB commented Aug 13, 2016

If we want a consistent design through all plugins, shouldn't the title in all plugins at the same place? In the controller the title is align to the left. And the background gots a specific gradient.

Edit: we could put the dB readout to the right site to align all elements at left.

@RebeccaDeField
Copy link
Contributor Author

RebeccaDeField commented Aug 13, 2016

@BaraMGB I did a quick search for other Spectrum Analyzers and it does seem that most put the db readout on the right (or both sides at once), but there are some that put it on the left. As long as we wouldn't be breaking any standards, I don't see any problem with changing the layout that way.

And the background has a specific gradient.

The background has the same gradient here that is used in the other plugins. 👍

@RebeccaDeField RebeccaDeField mentioned this pull request Aug 18, 2016
14 tasks
@RebeccaDeField
Copy link
Contributor Author

RebeccaDeField commented Aug 23, 2016

Updated spectrum analyzer design based on feedback:
image

@tresf I brightened the background colors and darkened the grid for more contrast as per your request :)

@BaraMGB I was going to move the db readout, but ended up removing the titles so I didn't see a reason to move it anymore. Please let me know if you would still like it on the right instead :)

@RebeccaDeField
Copy link
Contributor Author

RebeccaDeField commented Aug 23, 2016

I just noticed that the background needs to be tweaked. Will be updating that soon.

@BaraMGB
Copy link
Contributor

BaraMGB commented Aug 23, 2016

@RebeccaDeField Of course the readout is fine on the left without the title. 👍

@tresf
Copy link
Member

tresf commented Aug 24, 2016

This left my graphic a darker than I expected when I first put it in place. I brightened the colors to compensate, but I can absolutely bump the brightness up a notch if it's looking too dark on your computer.

The LEDs look too dark in general. They disappear into the background. I don't think this is a problem with the background but rather something with the new theme itself.

BEFORE vs. AFTER

image image

@RebeccaDeField
Copy link
Contributor Author

RebeccaDeField commented Aug 25, 2016

@tresf Just realized that I was thinking of the LED visualizer, but it seems you were actually referring to the Linear spectrum and Linear Y axis LEDs.

If so, do you find that they are too dim throughout the whole theme or just on this plugin? I have solutions for both scenarios.

@tresf
Copy link
Member

tresf commented Aug 25, 2016

do you find that they are too dim throughout the whole theme or just on this plugin? I have solutions for both scenarios.

Terrific question.

Well, upon reexamination, the whole theme (albeit less noticeable of an issue when nearby LEDs are lit or when the LED is a two-state LED) So my LED contrast comments are off-topic to this post and should be tracked in a separate issue.

@RebeccaDeField
Copy link
Contributor Author

RebeccaDeField commented Aug 25, 2016

@tresf I agree. It sounds like this is something separate from this particular plugin design.

The darker leds were one of the first elements I designed so with all of the color changes I believe they no longer have enough contrast with the rest of the theme. Lightening (probably) or darkening them (maybe) should be the solution. Because this seems pretty straightforward to me, I think I will go ahead and make a PR for it and if that doesn't fix the issue, further discussion can continue there. :)

@Umcaruje
Copy link
Member

Merging.

@Umcaruje Umcaruje merged commit cf824bd into LMMS:master Aug 25, 2016
@tresf tresf mentioned this pull request Sep 17, 2016
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* Redesign Spectrum Analyzer

* Update Spectrum Analyzer

* Update background
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants