Darker Background Art #1180
Closed
Darker Background Art #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkens the background art to make windows stand out more. Separate from background fix as this is a matter of aesthetics/subjective.
Fixes odd border on previous art.
|
We just updated the background art... why do you want to change it again? In the future, please discuss potential changes to UI/graphics on the mailing list or issue tracker before committing pull requests. |
|
@diizy Ok, sorry. Should I close this? I thought they could be separate since this is more subjective than the other one. |
|
Generally, we discuss potential changes on the mailing list or issue tracker before commiting them as pull requests. |
|
@diizy Ah ok. I thought issues were "Here's a problem, what do we do to fix it", and pull requests were "I have a solution/change I want to make, do you agree?". So should I close this or leave it? |
|
I think you should close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate from the earlier background change as this is entirely subjective. (If you'd rather I posted this change in that pull request please tell me).
