I did some profiling with Valgrind and it turns out that there are two main causes for the slow import of the aforementioned MIDI file (Twenty_4_Seven-Take_Me_Away.mid):

The call to TextFloat::displayMessage in AutomationPattern::addObject. It seems like TextFloat::displayMessage is called over and over again during the import (for that file).
The calls to createDetuning in Note::Note and Note::loadSettings. The main problem with createDetuning seems to be the sheer number of DetuningHelpers that are created during the import. The instances are created using the MemoryPool but even that seems to be of no help here. It might be that this problem can only be alleviated by changing the design. Does every note really need its own DetuningHelper?

If you comment out the aforementioned calls the import just flies.

The calls to createDetuning in the Note class also slow down the loading of LMMS project files by the way. You can reproduce this by profiling the loading of DnB.mmpz with Valgrind. So solving this problem would kill two birds with one stone and give users faster loading of projects and faster import of MIDI data.

Uh oh!

Midi Import hang #1971

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions