Skip to content

fix: On small screen, remove padding on left & right padding #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jul 29, 2025

This pull request includes updates to improve the layout and styling of the PhotoBox component, as well as minor code cleanup in the settings and CSS files.

Layout and Styling Improvements:

  • In resources/js/components/gallery/photoModule/PhotoBox.vue, updated the :class bindings for various elements to replace the max-wh-full-56 class with inline calculations (max-w-full md:max-w-[calc(100%-56px)] max-h-[calc(100%-56px)]) for more precise control over layout in fullscreen and slideshow modes. [1] [2] [3] [4]

Code Cleanup:

  • Removed the unused .max-wh-full-56 CSS class from resources/sass/app.css, as its functionality has been replaced by inline styles.
  • Updated the import statement in resources/js/views/Settings.vue to use a type import for MenuItem from primevue/menuitem, ensuring better type safety.

@ildyria ildyria requested a review from a team as a code owner July 29, 2025 07:19
@ildyria ildyria added Review: easy Easy review expected: probably just need a quick to go through. alpha-ready Branch is available in alpha labels Jul 29, 2025
@ildyria ildyria merged commit 60eaf4b into master Jul 29, 2025
35 checks passed
@ildyria ildyria deleted the display-without-padding branch July 29, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha-ready Branch is available in alpha Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants