Skip to content

Allow disabling "swipe up/down to go back" and "scroll to move between photos" gestures #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2025
Merged

Allow disabling "swipe up/down to go back" and "scroll to move between photos" gestures #3549

merged 5 commits into from
Jul 24, 2025

Conversation

cdzombak
Copy link
Contributor

I have found these two swipe/scroll handlers confusing myself, and I have watched people get confused by them especially when using my site on a phone.

This PR allows the option to disable them, but leaves them enabled by default.

@cdzombak cdzombak requested a review from a team as a code owner July 21, 2025 00:55
@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (40a92b5) to head (df64e60).
Report is 10 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ildyria
ildyria requested changes Jul 24, 2025
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes needed to be in line with the convention (yes that one is a bit unclear).

@cdzombak cdzombak requested a review from ildyria July 24, 2025 17:47
@ildyria ildyria merged commit 10e2d66 into LycheeOrg:master Jul 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdzombak @ildyria