Add throttling to login api: 10 tentative per hour #3539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
d7415
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a rate-limiting middleware to the login route in the API and adds a corresponding test to ensure the middleware functions as expected. The changes enhance security by mitigating brute-force login attempts.
Security Enhancements:
routes/api_v2.php: Added athrottle:10,60,loginmiddleware to the/Auth::loginroute to limit login attempts to 10 requests per minute.Testing Additions:
tests/Feature_v2/User/LoginTest.php: Created a newLoginTestclass to verify the rate-limiting middleware. The test simulates 10 failed login attempts, ensuring the 11th attempt returns a429 Too Many Requestsstatus.