Do not log queries which are faster than 100ms by default #3435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
tinohager
reviewed
Jun 11, 2025
| @@ -199,6 +199,11 @@ private function logSQL(QueryExecuted $query): void | |||
| return; | |||
| } | |||
|
|
|||
| // if the query is not slow enough, we do not log it. | |||
| if ($query->time < config('database.log_sql_min_time', 100)) { | |||
tinohager
reviewed
Jun 11, 2025
| | executed very fast and are not relevant for debugging. | ||
| | | ||
| */ | ||
| 'log_sql_min_time' => (int) env('DB_LOG_SQL_MIN_TIME', 100), |
tinohager
approved these changes
Jun 11, 2025
JasonMillward
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can focus on the slow queries.
This pull request introduces a feature to filter SQL query logging based on execution time, enhancing the application's debugging capabilities while reducing unnecessary log noise. The changes include adding a configuration option for a minimum query execution time and updating the logging logic accordingly.
Enhancements to SQL query logging:
app/Providers/AppServiceProvider.php: Updated thelogSQLmethod to skip logging SQL queries that execute faster than the configured minimum time (log_sql_min_time). This prevents logging insignificant queries.config/database.php: Added a new configuration option,log_sql_min_time, which allows setting a minimum execution time (in milliseconds) for SQL queries to be logged. This provides more control over the volume of logged queries.