Skip to content

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jun 9, 2025

This pull request introduces enhancements to user group management and access permission handling. Key changes include the addition of constants for user group attributes, modifications to access permission queries to incorporate user group-based permissions, and updates to ensure proper verification of feature availability.

User Group Management Enhancements:

Access Permission Handling:

  • app/Policies/AlbumQueryPolicy.php: Updated the getComputedAccessPermissionSubQuery method to include user group-based permissions in access queries. This ensures permissions can be evaluated based on both individual users and their associated user groups.

Feature Verification Updates:

Namespace Additions:

Dependency Inclusion:

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 98.96907% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (58caba6) to head (fcfb626).
Report is 5 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jun 9, 2025
@ildyria ildyria marked this pull request as ready for review June 9, 2025 21:36
@ildyria ildyria requested a review from a team as a code owner June 9, 2025 21:36
@ildyria ildyria force-pushed the user-groups/permissions branch from f5dc9d0 to 3756aa0 Compare June 11, 2025 13:56
@ildyria ildyria force-pushed the user-groups/permissions branch from 3756aa0 to 6dde592 Compare June 23, 2025 17:53
@ildyria
Copy link
Member Author

ildyria commented Jun 28, 2025

@sancsin thank you, I will wait for #3430 and #3432 to be also approved before merging. It does not make sense to complicate the queries when the other functionalities are not there yet. :)

@ildyria ildyria force-pushed the user-groups/permissions branch from 6dde592 to 2bbce04 Compare July 1, 2025 16:05
@ildyria ildyria merged commit 1cfa0c4 into master Jul 4, 2025
35 checks passed
@ildyria ildyria deleted the user-groups/permissions branch July 4, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants