-
-
Notifications
You must be signed in to change notification settings - Fork 349
Add Persian language and fix LTR and RTL display #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Co-authored-by: Foad Alavi <foad.alavi@nl.abnamro.com> Co-authored-by: Foad <foadalavi@gmail.com>
<span class="text-warning-700" | ||
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.transfer.lost_access_warning") }}</span | ||
><br /> | ||
<span class="text-warning-700"><i class="pi pi-exclamation-triangle mr-2" />{{ $t("dialogs.transfer.warning") }}</span> | ||
<span class="text-warning-700" | ||
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.transfer.warning") }}</span | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was like this already, but this seems an odd place to split lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the auto format is forcing it. :(
I will double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed bf6ffa1
<span class="text-warning-700" | ||
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.delete_album.warning") }}</span | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd place to split lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed bf6ffa1
<span class="text-warning-700" | ||
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("sharing.propagate_warning") }}</span | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd place to split lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed bf6ffa1
<span class="text-warning-700" | ||
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.delete_album.warning") }}</span | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd place to split lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed bf6ffa1
This pull request introduces several new language files for Persian (
fa
) translations, enhancing localization support for various pages and features in the application. Additionally, a minor adjustment was made to an Arabic (ar
) language file. The most important changes include adding translations for new pages, improving user interface elements, and fixing specific text alignment issues.Persian (
fa
) Localization Additionstemplates added.
Arabic (
ar
) Language File Adjustment:lang/ar/settings.php
: Fixed a text alignment issue by changing the icon's margin direction frommr-2
toml-2
for better visual consistency.