Skip to content

Add Persian language and fix LTR and RTL display #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 23, 2025
Merged

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jun 7, 2025

This pull request introduces several new language files for Persian (fa) translations, enhancing localization support for various pages and features in the application. Additionally, a minor adjustment was made to an Arabic (ar) language file. The most important changes include adding translations for new pages, improving user interface elements, and fixing specific text alignment issues.

Persian (fa) Localization Additions

templates added.

Arabic (ar) Language File Adjustment:

  • lang/ar/settings.php: Fixed a text alignment issue by changing the icon's margin direction from mr-2 to ml-2 for better visual consistency.

@ildyria ildyria added the Review: hard Difficult review expected: major changes, lots of files modified, and dependencies updated. label Jun 7, 2025
@ildyria ildyria requested a review from a team as a code owner June 7, 2025 13:52
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.51%. Comparing base (d237c84) to head (63f5666).
Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Foad Alavi <foad.alavi@nl.abnamro.com>
Co-authored-by: Foad <foadalavi@gmail.com>
@ildyria ildyria changed the title Add farsi template and fix LTR and RTL display Add Persian language and fix LTR and RTL display Jun 8, 2025
@ildyria ildyria added the alpha-ready Branch is available in alpha label Jun 10, 2025
Comment on lines 7 to 12
<span class="text-warning-700"
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.transfer.lost_access_warning") }}</span
><br />
<span class="text-warning-700"><i class="pi pi-exclamation-triangle mr-2" />{{ $t("dialogs.transfer.warning") }}</span>
<span class="text-warning-700"
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.transfer.warning") }}</span
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was like this already, but this seems an odd place to split lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the auto format is forcing it. :(
I will double check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bf6ffa1

Comment on lines 6 to 8
<span class="text-warning-700"
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.delete_album.warning") }}</span
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd place to split lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bf6ffa1

Comment on lines 11 to 13
<span class="text-warning-700"
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("sharing.propagate_warning") }}</span
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd place to split lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bf6ffa1

Comment on lines 7 to 9
<span class="text-warning-700"
><i class="pi pi-exclamation-triangle ltr:mr-2 rtl:ml-2" />{{ $t("dialogs.delete_album.warning") }}</span
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd place to split lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bf6ffa1

@ildyria ildyria merged commit ae1494c into master Jun 23, 2025
35 checks passed
@ildyria ildyria deleted the farsi/template branch June 23, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha-ready Branch is available in alpha Review: hard Difficult review expected: major changes, lots of files modified, and dependencies updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants