-
Notifications
You must be signed in to change notification settings - Fork 17
fix: exisiting support network #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n and action panel
Just tested it, it seems like the disconnect button doesn't work... |
what quickshell version you using? currently i'm using this version |
Why am I on 0.1.0 wtf lemme update //edit: |
@JPratama7 I found the issue. |
ahh i see, i remove quickshell prefix |
Yeah, do we wanna add it back or do you have any better idea so we don't run into breaking changes? |
i remove quickshell prefix because it will get conflict if i'm using nm-applet and it will make duplicate when inspecting using nmcli |
Ah I see... uhm I guess we could disconnect the quickshell- one and also the one without and then delete the quickshell-entry perhaps? Would force the people to enter the password once again though. |
that a good idea, lemme try |
Yeah please do so, we can then later remove the deletion of the quickshell- one, gonna update the readme so people know that they should reconnect once. |
@Ly-sec try this one, i change nmcli command to use ssid rather than profile id, so i don't need to modify nor delete anything |
Just tested, sadly results in the same. Perhaps we can just create a process:
Keep in mind the process was not tested yet, about to do it And then just run it in the |
i want to do that, but it will do delete without using user approval. should we use setting for that? |
That's a good call actually... uhm maybe a popup or an info + button in the panel ooor something when you open the wifi panel and it detects that a |
Maybe add a check for quickshell- and pop a modal up asking if the user gives permission to move over to the new naming? |
hmmm idk how to do that, for now i just remove prefix and replace it, wdyt? |
@ferrreo @JPratama7 I think I found a sleek fix: This literally just renames it, we could do that on the showAt function no? |
yup, try new commit @Ly-sec |
Tried it, no wifi connections are loading. Also I get //edit:
This works however we get an odd output in the terminal:
|
detect existing early when shell startup, add refresh button on wifi panel, i also change button from connect into a icon