Simple string hash for large strings #169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it fits into i386 registers, and consumes more than 2 bytes per cycle (on Haswell) + add check for hashsum equality in chain traversion.
|
Probably closes #168 |
|
Note, it doesn't protect from DoS hash-collision. Simplest platform independent function which I know that can resist "Seed Independent Collision" attack is at least three times slower, and it uses multiplication. |
|
@funny-falcon Great! I can confirm that this also fixes #168. |
|
This is even better with the latest changes to this pull request. |
Closed
|
Obsoleted by #174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it fits into i386 registers, do not use multiplication, and consumes more than 2 bytes per cycle
(on Haswell compiled as i386)