Include floats in calculation of minimum cell height #2301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We calculate the height of a cell by rendering the cell as a block after setting an auto height to the cell. This way, it can grow if needed. But setting the height attribute is not enough: we take care of floats in finish_block_formatting_context, that checks for the style value: we have to fake this value too. Related to #2216. Fix #2293.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We calculate the height of a cell by rendering the cell as a block after setting an auto height to the cell. This way, it can grow if needed.
But setting the height attribute is not enough: we take care of floats in finish_block_formatting_context, that checks for the style value: we have to fake this value too.
Related to #2216. Fix #2293.