Removed the dependency on the order of applying of the plugin #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the search for build variants takes place in the `afterEvaluate` action, which is added when `finalizeDsl` is called - thus the Kover code is guaranteed to be executed after creating variants. Additional changes: * added DSL accessors for Kover Default report tasks * added descriptions for Kover report tasks * added functions for getting Kover Android report task names Fixes #362 Fixes #394 Fixes #400
sandwwraith
requested changes
Jun 14, 2023
...gradle-plugin/src/functionalTest/templates/builds/android-inverse-order/app/build.gradle.kts
Show resolved
Hide resolved
...ionalTest/kotlin/kotlinx/kover/gradle/plugin/test/functional/framework/common/Environment.kt
Show resolved
Hide resolved
...t/kotlin/kotlinx/kover/gradle/plugin/test/functional/framework/runner/CustomizableRunning.kt
Outdated
Show resolved
Hide resolved
...-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/locators/CompilationsListeners.kt
Outdated
Show resolved
Hide resolved
...-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/locators/CompilationsListeners.kt
Outdated
Show resolved
Hide resolved
...-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/locators/CompilationsListeners.kt
Outdated
Show resolved
Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/locators/EmptyLocator.kt
Outdated
Show resolved
Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/tools/CoverageTool.kt
Outdated
Show resolved
Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/appliers/ProjectApplier.kt
Show resolved
Hide resolved
sandwwraith
approved these changes
Jun 15, 2023
eafb275 to
8135cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the search for build variants takes place in the
afterEvaluateaction, which is added whenfinalizeDslis called - thus the Kover code is guaranteed to be executed after creating variants.Additional changes:
Fixes #362
Fixes #394
Fixes #400