Skip to content

[K2] Do not inherit nested and inner classes #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2024
Merged

[K2] Do not inherit nested and inner classes #3397

merged 3 commits into from
Apr 2, 2024

Conversation

vmishenev
Copy link
Contributor

@vmishenev vmishenev commented Dec 4, 2023 •
edited
Loading

Current Dokka (K1) does not show inherited inner classes, but they are available from code in a class/enum scope, e.g.

    enum class A {
        E;
        inner class InnerClass
    }
    A.E.InnerClass() // is valid

or

     open class B {
        inner class InnerClass
    }

    class C:B()
    
    C().InnerClass() // is valid

@vmishenev vmishenev linked an issue Dec 4, 2023 that may be closed by this pull request
[K2] Java nested classed are shown in inheritors #3363
Closed
@vmishenev vmishenev force-pushed the vmishenev/3363-java-nested-class-should-not-be-in-inheritor branch from 7456e07 to fbe0968 Compare December 5, 2023 21:43
@vmishenev vmishenev changed the title [K2] Add test java nested classed should not be in inheritor [K2] Do not inherit nested and inner classes Mar 27, 2024
@vmishenev vmishenev force-pushed the vmishenev/3363-java-nested-class-should-not-be-in-inheritor branch from ec1a204 to 689dc40 Compare March 27, 2024 21:18
@vmishenev vmishenev marked this pull request as ready for review March 27, 2024 21:18
IgnatBeresnev
IgnatBeresnev approved these changes Apr 2, 2024
View reviewed changes
@vmishenev vmishenev merged commit cf485f3 into master Apr 2, 2024
@vmishenev vmishenev deleted the vmishenev/3363-java-nested-class-should-not-be-in-inheritor branch April 2, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyoleg whyoleg whyoleg approved these changes

@IgnatBeresnev IgnatBeresnev IgnatBeresnev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[K2] Java nested classed are shown in inheritors
3 participants
@vmishenev @IgnatBeresnev @whyoleg