fix: made code samples runnable (#3535) #3596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious: in future similar issues probably should be detected by ui-showcase screenshot tests, right? Is there a possibility there to check different browsers (Safari, Chrome, Firefox)? I believe in most cases just Chrome will be enough, so I'm just curious. |
IgnatBeresnev
approved these changes
May 7, 2024
|
@whyoleg Cases like this are rather hard to prevent only by tests from inside Dokka because of how scripts are included on a page is not totally under our control |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the problem with runnable code snippets detected in #3535 and described in #3553